Skip to content

feat: event pin 186#266

Merged
williscool merged 12 commits intomasterfrom
feat/event_pin_186
Apr 7, 2026
Merged

feat: event pin 186#266
williscool merged 12 commits intomasterfrom
feat/event_pin_186

Conversation

@williscool
Copy link
Copy Markdown
Owner

@williscool williscool commented Apr 6, 2026

  • docs: plan for event pinning
  • docs: plan update
  • feat: draw phase 1 through 4 of the owl

Note

Medium Risk
Medium risk because it changes core batch snoozeAll* behavior and introduces new bulk actions and UI state persisted in the event flags bitmask; regressions would mostly affect notification list interactions and snooze workflows.

Overview
Introduces event pinning by adding an IS_PINNED bit in EventAlertRecord.flags plus UI affordances to pin/unpin from the active list (new pin icon toggle) and from the event detail popup menu.

Updates batch behavior so snoozeAllEvents and snoozeAllCollapsedEvents skip pinned events, adjusts the Snooze vs Change All decision to consider only unpinned active events, and passes a new INTENT_PINNED_EVENT_COUNT into SnoozeAllActivity to append an “excluded pinned” note in confirmations.

Adds overflow-menu Pin all visible / Unpin all actions wired to new ApplicationController.pinAllVisibleEvents and unpinAllVisibleEvents, extends FilterState.StatusOption with PINNED/UNPINNED, and adds comprehensive instrumentation/Robolectric coverage plus a design doc (docs/dev_todo/event_pinning.md).

Reviewed by Cursor Bugbot for commit bd7c66c. Bugbot is set up for automated code reviews on this repo. Configure here.

@williscool williscool changed the title feat/event pin 186 feat: event pin 186 Apr 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

Code Coverage Report

Overall Project 34.38% -0.41% 🍏
Files changed 53.52%

Module Coverage
app 41.3% -0.44%
x8664Debug 27.61% -0.37%
Files
Module File Coverage
app Consts.kt 98.9% 🍏
ApplicationController.kt 66.98% -0.29% 🍏
EventAlertRecord.kt 60.48% 🍏
FilterState.kt 56.1% -1.8% 🍏
ActiveEventsFragment.kt 52.42% -6.73%
SnoozeAllActivity.kt 50.45% -1.19%
ViewEventActivityNoRecents.kt 49.87% -3.23%
SearchableFragment.kt 48.48% -18.18%
MainActivityModern.kt 48.37% -4.92%
EventListAdapter.kt 42.37% -1.38% 🍏
x8664Debug FilterState.kt 93.2% -1.5% 🍏
ApplicationController.kt 60.19% -0.22% 🍏
EventAlertRecord.kt 59.86% 🍏
EventListAdapter.kt 49.88% -1.38% 🍏
MainActivityModern.kt 49.38% -4.92%
ViewEventActivityNoRecents.kt 48.48% -2.2%
SearchableFragment.kt 48.48% -18.18%
ActiveEventsFragment.kt 47.66% -6.73%
SnoozeAllActivity.kt 39.13% 🍏
Consts.kt 0% 🍏

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

📊 Code Coverage Summary

Coverage Type Coverage
Overall null
Changed Files 100

View detailed coverage report

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

Build artifacts for PR #266 (commit 3b7ba0a) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

📊 Code Coverage Summary

Coverage Type Coverage
Overall 34.38
Changed Files 56.07

View detailed coverage report

Comment thread android/app/src/main/res/values/strings.xml Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

Build artifacts for PR #266 (commit ce9494d) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

📊 Code Coverage Summary

Coverage Type Coverage
Overall 27.6
Changed Files 53.85

View detailed coverage report

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 82088fc. Configure here.

Comment thread android/app/src/main/java/com/github/quarck/calnotify/ui/EventListAdapter.kt Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

Build artifacts for PR #266 (commit 82088fc) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

📊 Code Coverage Summary

Coverage Type Coverage
Overall 27.61
Changed Files 53.87

View detailed coverage report

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

Build artifacts for PR #266 (commit bd7c66c) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

@williscool williscool merged commit 9c1a1b2 into master Apr 7, 2026
15 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

📊 Code Coverage Summary

Coverage Type Coverage
Overall 34.38
Changed Files 54.7

View detailed coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant