Close response streams on terminal validation errors - #83
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 8 8
Lines 1460 1561 +101
==========================================
+ Hits 1460 1561 +101
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
If validate_response raises ValueError, the transport raises before HTTPX receives the response. Its unread stream stays open.
Both transport paths now close the discarded response before raising. This also handles an asyncio task cancelled while validation is awaiting.
Retryable validation errors keep their existing retry flow. Successful streamed responses stay open for the caller.
Added seven cases using unread streams and a real cancelled task. Five fail on the original transport code.
scripts/test passes all 159 tests with 100% coverage on Python 3.10 through 3.14. scripts/check passes on all five versions.
scripts/build passes on Python 3.10 and 3.14, including the strict docs build.
The scripts/test-fork harness passes all 159 tests with HTTPX_BACKEND=httpxyz and HTTPX_BACKEND=httpx2 on Python 3.13.
httpxyz emits one pytest assertion rewrite warning.