DonationReminderV3: end-of-experiment screens - #6845
Open
cooltey wants to merge 8 commits into
Open
Conversation
cooltey
requested review from
Williamrai,
dbrant and
voyagerfan
as code owners
September 1, 2026 00:25
There was a problem hiding this comment.
Pull request overview
Adds end-of-experiment experiences for Donation Reminder V3.
Changes:
- Adds wrap-up cards and feedback survey UI.
- Adds a monthly donation path with recurring Google Pay preselection.
- Adds wrap-up scheduling, persistence, and developer controls.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
app/src/main/res/xml/developer_preferences.xml |
Adds the developer wrap-up toggle. |
app/src/main/res/values/preference_keys.xml |
Defines the toggle鈥檚 preference key. |
app/src/main/res/layout/view_donation_reminder_card.xml |
Adds wrap-up labeling and learn-more UI. |
app/src/main/res/drawable/ic_open_in_new_black_16px.xml |
Adds the external-link icon. |
app/src/main/java/org/wikipedia/views/SurveyDialog.kt |
Adds the wrap-up feedback survey. |
app/src/main/java/org/wikipedia/settings/Prefs.kt |
Persists the developer override. |
app/src/main/java/org/wikipedia/settings/dev/DeveloperSettingsPreferenceLoader.kt |
Handles wrap-up developer controls. |
app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.kt |
Displays the appropriate reminder variant. |
app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.kt |
Routes wrap-up actions to survey or donation. |
app/src/main/java/org/wikipedia/donate/donationreminder/DonationReminderHelper.kt |
Adds wrap-up dates and state handling. |
app/src/main/java/org/wikipedia/donate/donationreminder/DonationReminderCardView.kt |
Supports wrap-up content and external navigation. |
app/src/main/java/org/wikipedia/donate/DonateDialog.kt |
Adds the monthly donation presentation. |
app/src/extra/java/org/wikipedia/donate/GooglePayViewModel.kt |
Reads the recurring-donation default. |
app/src/extra/java/org/wikipedia/donate/GooglePayComponent.kt |
Propagates recurring-donation intent state. |
app/src/extra/java/org/wikipedia/donate/GooglePayActivity.kt |
Preselects recurring donations. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T435550