Skip to content

Feature/logger#48

Open
RYNEQ wants to merge 6 commits into
mainfrom
feature/logger
Open

Feature/logger#48
RYNEQ wants to merge 6 commits into
mainfrom
feature/logger

Conversation

@RYNEQ

@RYNEQ RYNEQ commented May 4, 2022

Copy link
Copy Markdown
Collaborator

print messages are converted to logger messages
we now have --log CLI parameter which defaults to debug and prints all messages

  • Obvious error and warning messages are in correct level.
  • Packet details are in debug level
  • decoratives, informatives and Morse codes are in info level (Cleanup and enhancements are required)

Also current message format is %(message)s so only the message itself is logged; we need to categorize sections/modules/functions and decide for a appropriate message format (time, section, level, message, ...)

@RYNEQ

RYNEQ commented May 4, 2022

Copy link
Copy Markdown
Collaborator Author

Should we change the --log {critical,error,warning,info,debug} behavior to something like -v for warning, -vv for info and -vvv for debug ?
This seems simpler

@xhdix

xhdix commented May 5, 2022

Copy link
Copy Markdown
Contributor

-vvv seems more idiomatic, thanks a lot!

@xhdix xhdix self-requested a review May 5, 2022 18:15
@xhdix xhdix added enhancement New feature or request priority/medium labels May 5, 2022
@RYNEQ

RYNEQ commented May 7, 2022

Copy link
Copy Markdown
Collaborator Author

-vvv seems more idiomatic, thanks a lot!

Now -v, -vv and -vvv are available for warinig, info, debug levels and default verbosity is error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority/medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants