Rename record type to cache_record type to fix compilation on Erlang 29.0#433
Open
TBK145 wants to merge 1 commit intowhitfin:mainfrom
Open
Rename record type to cache_record type to fix compilation on Erlang 29.0#433TBK145 wants to merge 1 commit intowhitfin:mainfrom
TBK145 wants to merge 1 commit intowhitfin:mainfrom
Conversation
…29.0 Erlang 29 (release candidate 1) doesn't allow built-in types (like record) to be redefined.
Author
|
I'm thinking now that I misinterpreted the issue, and it was already not allowed to redefine built-in types, but Erlang 29 ships with |
Owner
|
Hi @TBK145, thanks for reporting! I don't have spare time right now, but I can definitely look into this and make sure we fully understand what changed. Fortunately I'm planning a major version anyway, so the breaking change here won't matter as much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Erlang 29 (release candidate 1) doesn't allow built-in types (like record) to be redefined.
This leads to the following compilation error:
I renamed the type
recordtocache_recordto fix this.