Don't crash writing the log when a track was skipped#694
Open
mkoester wants to merge 1 commit into
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
A track that fails every rip attempt is marked skipped and never gets a peak level, leaving trackResult.peak as None. writeLog() -> trackLog() then did an unconditional `trackResult.peak / 32768.0`, raising `TypeError: unsupported operand type(s) for /: 'NoneType' and 'float'` and aborting the whole run *after* every other track had ripped fine, so no log or cue file was written. This is easy to hit on enhanced/CD-Extra discs: the last audio track (right before the trailing data track) often fails to read, gets skipped with -k, and then takes the log-writer down. Guard the peak line so the "Peak level" entry is simply omitted for a track without a peak, matching cd.py which already avoids the same division for skipped tracks. Add a regression test covering a rip that contains a skipped track. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Mirko Köster <git@mirkokoester.de>
mkoester
force-pushed
the
fix/log-skipped-track-peak-none
branch
from
July 20, 2026 15:19
32f2b3d to
27bca97
Compare
mkoester
marked this pull request as ready for review
July 20, 2026 15:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A track that fails every rip attempt is marked skipped and never gets a
peak level, leaving trackResult.peak as None. writeLog() -> trackLog()
then did an unconditional
trackResult.peak / 32768.0, raisingTypeError: unsupported operand type(s) for /: 'NoneType' and 'float'and aborting the whole run after every other track had ripped fine, so
no log or cue file was written.
This is easy to hit on enhanced/CD-Extra discs: the last audio track
(right before the trailing data track) often fails to read, gets skipped
with -k, and then takes the log-writer down.
Guard the peak line so the "Peak level" entry is simply omitted for a
track without a peak, matching cd.py which already avoids the same
division for skipped tracks. Add a regression test covering a rip that
contains a skipped track.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com