PEP 825: add a short note for installing from a local directory#49
PEP 825: add a short note for installing from a local directory#49mgorny wants to merge 2 commits intopep-wheel-variants-acceptancefrom
Conversation
Signed-off-by: Michał Górny <mgorny@quansight.com>
Documentation build overview
698 files changed ·
|
| wheels. The remaining steps correspond to the current installer | ||
| behavior. | ||
|
|
||
| When a local directory is provided rather than a remote index, the same |
There was a problem hiding this comment.
As far as the standards are concerned, a local directory does not exist: PEP 508 only support version specifiers, repos and files, and from the other direction the local directory doesn't speak the index api. That's a spec concern though, tools do the evident thing and use the directory like an index.
What about: If a separate variants-<...>.json for all wheels in consideration isn't available, variant metadata must be read directly from each wheel.
There was a problem hiding this comment.
It's a non-normative part, so I wouldn't be that concerned. However, I don't think we want to encourage reading metadata directly from remote files — this will definitely be picked on.
There was a problem hiding this comment.
We're already reading a file from a remote file for METADATA if PEP 658 isn't supported, I can defend this in the discussion, I don't think we need to yield on that.
There was a problem hiding this comment.
Hmm, but then we'd actually have to change the spec, since it says that it "MUST be present".
There was a problem hiding this comment.
I mainly wouldn't talk about local directories as a concept, but we can more generally say that if you obtain wheels from a source that doesn't give you a variants.json, you need to read the variant information from the wheel.
There was a problem hiding this comment.
Yeah, I suppose that's a loophole we could use.
Signed-off-by: Michał Górny <mgorny@quansight.com>
3 participants
📚 Documentation preview 📚: https://wheelnext-peps--49.org.readthedocs.build/