Open
Conversation
(which were used for easier development)
internal helper functions
and clean up code slightly
Contributor
Author
|
@whatyouhide Just a gentle reminder in case the notification of this PR slipped through the cracks. Of course, take your time, and happy new-year's holidays! 😊 |
Qqwy
changed the title
whatyouhide
reviewed
Jan 18, 2022
Owner
|
I like where this is going. Is there any way we can use |
Contributor
Author
I think this should be possible, at least for most of the cases. 👍 |
Qqwy
changed the title
Munksgaard
added a commit
to Munksgaard/stream_data
that referenced
this pull request
Aug 24, 2025
This is a reimplementation of the date generators by @Qqwy in whatyouhide#161. The tests and documentation are entirely copy-pasted from his PR, but the actual implementation is entirely new. As noted by @whatyouhide in a comment to the original PR, I've opted to use the new `Date.add` function for most of the cases. I think the resulting implementation is a bit easier to follow. Co-authored-by: Qqwy / Marten <w-m@wmcode.nl>
Munksgaard
added a commit
to Munksgaard/stream_data
that referenced
this pull request
Aug 24, 2025
This is a reimplementation of the date generators by @Qqwy in whatyouhide#161. As such, it is a (partial) implementation for whatyouhide#129. The tests and documentation are entirely copy-pasted from his PR, but the actual implementation is entirely new. As noted by @whatyouhide in a comment to the original PR, I've opted to use the new `Date.add` function for most of the cases. I think the resulting implementation is a bit easier to follow. I have not added Time, DateTime or NaiveDateTime, though I think we could probably do something for those that follow this skeleton. Co-authored-by: Qqwy / Marten <w-m@wmcode.nl>
Merged
Munksgaard
added a commit
to Munksgaard/stream_data
that referenced
this pull request
Aug 28, 2025
This is a reimplementation of the date generators by @Qqwy in whatyouhide#161. As such, it is a (partial) implementation for whatyouhide#129. The tests and documentation are entirely copy-pasted from his PR, but the actual implementation is entirely new. As noted by @whatyouhide in a comment to the original PR, I've opted to use the new `Date.add` function for most of the cases. I think the resulting implementation is a bit easier to follow. I have not added Time, DateTime or NaiveDateTime, though I think we could probably do something for those that follow this skeleton. Co-authored-by: Qqwy / Marten <w-m@wmcode.nl> Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
Munksgaard
added a commit
to Munksgaard/stream_data
that referenced
this pull request
Aug 29, 2025
This is a reimplementation of the date generators by @Qqwy in whatyouhide#161. As such, it is a (partial) implementation for whatyouhide#129. The tests and documentation are entirely copy-pasted from his PR, but the actual implementation is entirely new. As noted by @whatyouhide in a comment to the original PR, I've opted to use the new `Date.add` function for most of the cases. I think the resulting implementation is a bit easier to follow. I have not added Time, DateTime or NaiveDateTime, though I think we could probably do something for those that follow this skeleton. Co-authored-by: Qqwy / Marten <w-m@wmcode.nl> Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
whatyouhide
added a commit
that referenced
this pull request
Sep 2, 2025
This is a reimplementation of the date generators by @Qqwy in #161. As such, it is a (partial) implementation for #129. The tests and documentation are entirely copy-pasted from his PR, but the actual implementation is entirely new. As noted by @whatyouhide in a comment to the original PR, I've opted to use the new `Date.add` function for most of the cases. I think the resulting implementation is a bit easier to follow. I have not added Time, DateTime or NaiveDateTime, though I think we could probably do something for those that follow this skeleton. Co-authored-by: Qqwy / Marten <w-m@wmcode.nl> Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of #129
So far a generator function has added to create
Datestructs, including the accompanying tests.The implementation for
Time,DateTimeandNaiveDateTimewill be similar, except that their unit of offset will be fractions of milliseconds (rather than days), and of course theDate.Range-related code does not apply.Since their implementation will be very similar, this seemed like a good moment to give you the opportunity to provide initial feedback on the code.
Happy holidays! 🎆