Skip to content

Set requests' user activation flag during navigation.#5203

Merged
annevk merged 7 commits into
mainfrom
user-activation
Mar 4, 2021
Merged

Set requests' user activation flag during navigation.#5203
annevk merged 7 commits into
mainfrom
user-activation

Conversation

@mikewest

@mikewest mikewest commented Jan 10, 2020

Copy link
Copy Markdown
Member

In order to support Fetch Metadata's Sec-Fetch-User header, this patch
sets navigation requests' user activation flag if the navigation is
triggered while the source browsing context has transient activation.


/browsing-the-web.html ( diff )
/infrastructure.html ( diff )

In order to support Fetch Metadata's `Sec-Fetch-User` header, this patch
sets navigation requests' user activation flag if the navigation is
triggered while the source browsing context has transient activation.
@mikewest

Copy link
Copy Markdown
Member Author

(Note that this patch depends on whatwg/fetch#993 landing first.)

@annevk annevk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks accurate. @mustaqahmed want to double check?

@mustaqahmed

Copy link
Copy Markdown
Contributor

This looks good from user activation perspective.

Two questions/nits:

  • The corresponding fetch PR adds "user-activation flag" (with the hyphen). Perhaps we can do the same here?
  • Any chance the fetch API may also add the sticky activation state in future? If yes, we can consider switching the type from Boolean to "UserActivation" which is proposed in Sec 6.3.4 in this PR.

@domenic

domenic commented Feb 7, 2020

Copy link
Copy Markdown
Member

Ping @annevk @mikewest on finishing this up.

@mikewest

Copy link
Copy Markdown
Member Author

Thanks, @mustaqahmed (and @domenic for the ping)!

I've added the hyphen to user-activation flag. I'd like to hold off on the sticky activation state, as I don't know of any current plans to use that at the Fetch layer. It's not a terribly complicated thing to add, but since #4009 hasn't landed yet, I'd like not to block this on that.

WDYT, @annevk?

Base automatically changed from master to main January 15, 2021 07:57
@mikewest

mikewest commented Mar 2, 2021

Copy link
Copy Markdown
Member Author

Today's commits merge in the last few months of changes, and adjusts the patch to talk about a request's "user activation" boolean, per the rename in whatwg/fetch#993.

@annevk annevk merged commit 1398653 into main Mar 4, 2021
@annevk annevk deleted the user-activation branch March 4, 2021 08:28
mikewest added a commit to w3c/webappsec-fetch-metadata that referenced this pull request Jul 13, 2021
After whatwg/fetch#948,
whatwg/fetch#993, and
whatwg/html#5203, the integration with Fetch and
HTML is complete. This patch points to those integration points rather
than claiming that there's still work to be done.

Closes #73.
mikewest added a commit to w3c/webappsec-fetch-metadata that referenced this pull request Jul 20, 2021
After whatwg/fetch#948,
whatwg/fetch#993, and
whatwg/html#5203, the integration with Fetch and
HTML is complete. This patch points to those integration points rather
than claiming that there's still work to be done.

Closes #73.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants