Fix dialog closedby and requestClose() (take 2)#11326

Merged

zcorpan merged 34 commits into

whatwg:mainfrom

keithamus:remove-dialog-open-clear-list

Aug 27, 2025

Commits on May 21, 2025

Add attribute changed steps to dialog element

lukewarlow
authored and
keithamus
committed
Replace assert in set the dialog close watcher with an early return

lukewarlow
authored and
keithamus
committed
Add dialog attribute change steps when adding open attribute

lukewarlow
authored and
keithamus
committed
Run specfmt

lukewarlow
authored and
keithamus
committed
Define dialog cleanup and setup steps and call them from the attribute changed steps

lukewarlow
authored and
keithamus
committed
Call dialog cleanup steps from dialog removing steps

lukewarlow
authored and
keithamus
committed
Define dialog HTML element insertion steps and call dialog setup steps

lukewarlow
authored and
keithamus
committed
Replace early return with assert

lukewarlow
authored and
keithamus
committed
Revert "Replace early return with assert"

lukewarlow
authored and
keithamus
committed
Add connected check to dialog insertion steps

lukewarlow
authored and
keithamus
committed
Attempt at fixing issues

lukewarlow
authored and
keithamus
committed
Add back destroy of close watcher to cleanup steps

lukewarlow
authored and
keithamus
committed
remove errenous div
keithamus
committed
add many asserts
keithamus
committed
return early if dialog is not connected during setup
keithamus
committed
return early in requestclose if dialog is not connected
keithamus
committed
specfmt
keithamus
committed
s/active document/node document
keithamus
committed

Commits on May 22, 2025

Commits on Jun 19, 2025

s/code/span
keithamus
committed