Don't run light dismiss on right click#11185
Closed
josepharhar wants to merge 1 commit into
Closed
Conversation
This fixes a bug where showing a popover during the contextmenu event handler immediately gets light dismissed as soon as the user lifts up on the mouse button because the contextmenu event is fired in between pointerdown and pointerup. Fixes whatwg#10905
domenic
added
normative change
topic: dialog
Contributor
Author
|
This would alternatively be addressed by this, so I'm not sure we should merge this PR at this time w3c/pointerevents#542 (comment) |
6 tasks
Contributor
Author
|
closing this in favor of #11536 |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where showing a popover during the contextmenu event handler immediately gets light dismissed as soon as the user lifts up on the mouse button because the contextmenu event is fired in between pointerdown and pointerup.
Fixes #10905
(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/interactive-elements.html ( diff )