Add new locking modes to file handle primitives#151
Open
nathanmemmott wants to merge 4 commits into
Open
Conversation
a-sully
reviewed
Nov 14, 2023
a-sully
left a comment
a-sully
left a comment
Collaborator
There was a problem hiding this comment.
Lots of nits, but the overall shape of this change LGTM
nathanmemmott
force-pushed
the
new_sah_and_wfs_lock_modes
branch
from
bc3475c to
0eb043a
Compare
5 tasks
nathanmemmott
force-pushed
the
new_sah_and_wfs_lock_modes
branch
2 times, most recently
from
dc89f60 to
3f084f0
Compare
nathanmemmott
force-pushed
the
new_sah_and_wfs_lock_modes
branch
from
3f084f0 to
9475e66
Compare
a-sully
approved these changes
Nov 21, 2023
a-sully
left a comment
a-sully
left a comment
Collaborator
There was a problem hiding this comment.
LGTM but it would be nice to get eyes on this from another implementer before merging
nathanmemmott
force-pushed
the
new_sah_and_wfs_lock_modes
branch
from
9475e66 to
e9ba03b
Compare
Contributor
Author
added 4 commits
December 19, 2023 15:17
Adds new locking modes for sync access handles and writable file streams. Updates "file entry/take a lock" and "file entry/lock/release" to support these new modes.
nathanmemmott
force-pushed
the
new_sah_and_wfs_lock_modes
branch
from
e9ba03b to
564df68
Compare
This was referenced Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new locking modes to file handle primitives
Writable file streams and sync access handles can now be created with an optional "mode" parameter.
For sync access handles, "mode" can be "readwrite", "readonly", or "readwrite-unsafe". "readwrite" is the current behavior and the default if "mode" is not specified. Only one sync access handle can be open on a file handle in this mode. The two new modes, "readonly" and "readwrite-unsafe", are shared modes which are added to support multiple readers and writers.
For writable file streams, "mode" can be "exclusive" or "siloed". "siloed" is the current behavior and the default if "mode" is not specified. This mode allows multiple writers to clobber each other. The new "exclusive" mode is added to prevent this clobbering.
For a more detailed explanation, see Multiple Readers and Writers explainer: https://github.com/whatwg/fs/blob/main/proposals/MultipleReadersWriters.md.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff