Skip to content

Modernize javascript toolchain#233

Merged
relf merged 3 commits into
masterfrom
upgrade-xdsmjs
May 5, 2026
Merged

Modernize javascript toolchain#233
relf merged 3 commits into
masterfrom
upgrade-xdsmjs

Bump xdsmjs version to 2.0.1

0c0172b
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action May 5, 2026 in 0s

134 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 36
- Added 134
           

Complexity increasing per file
==============================
- app/javascript/mda_viewer/components/ConnectionsEditor.jsx  1
- app/javascript/mda_viewer/components/DisciplinesEditor.jsx  2
         

Complexity decreasing per file
==============================
+ app/javascript/mda_viewer/index.jsx  -2
         

See the complete overview on Codacy

Annotations

Check warning on line 73 in app/javascript/application_views/analyses_index.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/application_views/analyses_index.js#L73

Do not use jQuery

Check warning on line 23 in app/javascript/application_views/operations_index.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/application_views/operations_index.js#L23

Do not use jQuery

Check warning on line 25 in app/javascript/application_views/operations_index.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/application_views/operations_index.js#L25

Do not use jQuery

Check warning on line 25 in app/javascript/application_views/operations_index.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/application_views/operations_index.js#L25

Don't use jQuery without Ember Run Loop

Check warning on line 32 in app/javascript/application_views/operations_index.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/application_views/operations_index.js#L32

Do not use jQuery

Check warning on line 38 in app/javascript/application_views/operations_index.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/application_views/operations_index.js#L38

Do not use jQuery

Check warning on line 15 in app/javascript/mda_viewer/components/AnalysisEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/AnalysisEditor.jsx#L15

Button elements must have a data-test-id attribute.

Check warning on line 18 in app/javascript/mda_viewer/components/AnalysisEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/AnalysisEditor.jsx#L18

Button elements must have a data-test-id attribute.

Check warning on line 18 in app/javascript/mda_viewer/components/AnalysisEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/AnalysisEditor.jsx#L18

Elements with an onClick handler must have a data-test-id attribute.

Check warning on line 22 in app/javascript/mda_viewer/components/AnalysisEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/AnalysisEditor.jsx#L22

Function Call Object Injection Sink

Check warning on line 143 in app/javascript/mda_viewer/components/AnalysisEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/AnalysisEditor.jsx#L143

disallow literal string: <div className="editor-section-label">
            <i className="fas fa-info-circle" title="Analysis general informations" /> General
            Information
          </div>

Check warning on line 148 in app/javascript/mda_viewer/components/AnalysisEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/AnalysisEditor.jsx#L148

disallow literal string: <div className="editor-section-label">Name</div>

Check warning on line 158 in app/javascript/mda_viewer/components/AnalysisEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/AnalysisEditor.jsx#L158

disallow literal string: <div className="editor-section-label">Design Project</div>

Check warning on line 175 in app/javascript/mda_viewer/components/AnalysisEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/AnalysisEditor.jsx#L175

Button elements must have a data-test-id attribute.

Check warning on line 175 in app/javascript/mda_viewer/components/AnalysisEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/AnalysisEditor.jsx#L175

disallow literal string: <button type="submit" className="btn btn-primary ms-3">
              Save
            </button>

Check warning on line 191 in app/javascript/mda_viewer/components/AnalysisEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/AnalysisEditor.jsx#L191

disallow literal string: <div className="editor-section-label">
            <i className="fas fa-user-secret" title="Analysis with restricted access" /> Privacy{' '}
            <small>(when restricted, allow read only access to the users listed below)</small>
          </div>

Check warning on line 73 in app/javascript/mda_viewer/components/ConnectionsEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/ConnectionsEditor.jsx#L73

Button elements must have a data-test-id attribute.

Check warning on line 256 in app/javascript/mda_viewer/components/ConnectionsEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/ConnectionsEditor.jsx#L256

Button elements must have a data-test-id attribute.

Check warning on line 7 in app/javascript/mda_viewer/components/DisciplinesEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/DisciplinesEditor.jsx#L7

Can't resolve '@atlaskit/pragmatic-drag-and-drop/element/adapter' in '/src/app/javascript/mda_viewer/components'

Check warning on line 12 in app/javascript/mda_viewer/components/DisciplinesEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/DisciplinesEditor.jsx#L12

Can't resolve '@atlaskit/pragmatic-drag-and-drop-hitbox/closest-edge' in '/src/app/javascript/mda_viewer/components'

Check notice on line 270 in app/javascript/mda_viewer/components/DisciplinesEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/DisciplinesEditor.jsx#L270

Don’t use conditional expressions inside JSX; they generally make your component harder to read. Instead, break that expression out into its own variable, and include the variable in JSX.

Check warning on line 289 in app/javascript/mda_viewer/components/DisciplinesEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/DisciplinesEditor.jsx#L289

Elements with an onChange handler must have a data-test-id attribute.

Check warning on line 296 in app/javascript/mda_viewer/components/DisciplinesEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/DisciplinesEditor.jsx#L296

disallow literal string: <option value={DISCIPLINE}>Discipline</option>

Check warning on line 303 in app/javascript/mda_viewer/components/DisciplinesEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/DisciplinesEditor.jsx#L303

disallow literal string: <button type="submit" className="btn btn-primary ms-3">
                  Update
                </button>

Check warning on line 308 in app/javascript/mda_viewer/components/DisciplinesEditor.jsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/javascript/mda_viewer/components/DisciplinesEditor.jsx#L308

Button elements must have a data-test-id attribute.