Add workflow for building Windows installer#111
Conversation
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 85.36% 85.36%
=======================================
Files 19 19
Lines 1640 1640
=======================================
Hits 1400 1400
Misses 240 240 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hey there! IMO linux and mac don't really need an installer, distributing the executable has been good enough in my experience. |
|
https://github.com/jspaezp/mokapot/actions/runs/6710019031/job/18234321059 |
1cc33b2 to
67ee2a7
Compare
|
Hi @jspaezp, I rebased the branch to the latest changes on main. However, I might wait for #125 to be merged before continuing here, as this PR also updates the actions. Regarding the relative imports: It seems like they would all need to be updated. Is there a reason relative imports (e.g. Best, |
|
I don't really believe there is a specific reason why relative imports are used rather than absolute. I can definitely look into patching it later ... Once we stabilize the main branch ... |
This PR partially addresses #101:
pyinstaller.specinstructs PyInstaller to freeze mokapot with all its dependencies (including Python) in an executable.innosetup.issinstructs InnoSetup to bundle everything in a Windows Installer exe..github/workflows/publish.ymlto go through the above two steps and upload the exe as an asset to the release.What is still needed to fully implement #101:
I don't have any experience with these open issues, so I leave them open for someone else to tackle.