fix(ocr): 恢复中英文自动推荐的旧版模型 - #793
Merged
Merged
Conversation
|
⏳ CI 检查进行中,报告将在完成后更新。 |
审阅者指南(在小型 PR 上折叠)审阅者指南更新 OCR 默认设置,使英文和简体中文自动配置文件使用旧版 AlOCR 模型,并将文档 / agent / i18n 描述与新行为保持一致。 更新后 OCR 默认模型选择的流程图flowchart LR
AutoProfile[Auto profile selection]
LangEN[English azur_lane]
LangCN[Simplified Chinese cn]
LangJP[Japanese jp]
LangTW[Traditional Chinese tw]
AutoProfile --> LangEN
AutoProfile --> LangCN
AutoProfile --> LangJP
AutoProfile --> LangTW
LangEN --> ModelEN[DEFAULT_ONNX_MODEL_VERSION.azur_lane = alocr_en_v2_6]
LangCN --> ModelCN[DEFAULT_ONNX_MODEL_VERSION.cn = alocr_cn_v3]
LangJP --> ModelJP[DEFAULT_ONNX_MODEL_VERSION.jp = standard]
LangTW --> ModelTW[DEFAULT_ONNX_MODEL_VERSION.tw = standard]
文件级改动
技巧和命令与 Sourcery 交互
自定义你的使用体验访问你的 dashboard 以:
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate OCR defaults so English and Simplified Chinese auto profiles use legacy AlOCR models, and align documentation/agent/i18n descriptions with the new behavior. Flow diagram for updated OCR default model selectionflowchart LR
AutoProfile[Auto profile selection]
LangEN[English azur_lane]
LangCN[Simplified Chinese cn]
LangJP[Japanese jp]
LangTW[Traditional Chinese tw]
AutoProfile --> LangEN
AutoProfile --> LangCN
AutoProfile --> LangJP
AutoProfile --> LangTW
LangEN --> ModelEN[DEFAULT_ONNX_MODEL_VERSION.azur_lane = alocr_en_v2_6]
LangCN --> ModelCN[DEFAULT_ONNX_MODEL_VERSION.cn = alocr_cn_v3]
LangJP --> ModelJP[DEFAULT_ONNX_MODEL_VERSION.jp = standard]
LangTW --> ModelTW[DEFAULT_ONNX_MODEL_VERSION.tw = standard]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - 我在这里给出了一些整体性的反馈:
- 建议在
DEFAULT_ONNX_MODEL_VERSION附近添加一段简短的行内注释,说明为什么英语 / 碧蓝航线(Azur Lane)和简体中文默认使用旧版(legacy)模型,而日文 / 繁中(JP/TW)保持为standard,以帮助后续维护者理解这种“混合默认值”配置背后的原因。 - 请再次确认
DEFAULT_ONNX_MODEL_VERSION中的键(如azur_lane、cn等)是否与auto被解析时使用的逻辑模型标识完全一致;如果命名有任何偏差,可能会在无提示的情况下回退到非预期的默认值。
给 AI 代理(Agents)的提示
Please address the comments from this code review:
## Overall Comments
- Consider adding a brief inline comment near `DEFAULT_ONNX_MODEL_VERSION` explaining why English/Azur Lane and Simplified Chinese default to legacy models while JP/TW stay on `standard`, to help future maintainers understand the mixed-default rationale.
- Double-check that the keys in `DEFAULT_ONNX_MODEL_VERSION` (`azur_lane`, `cn`, etc.) exactly match the logical model identifiers used when `auto` is resolved; if any naming diverges, it could silently fall back to unintended defaults.帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English
Hey - I've left some high level feedback:
- Consider adding a brief inline comment near
DEFAULT_ONNX_MODEL_VERSIONexplaining why English/Azur Lane and Simplified Chinese default to legacy models while JP/TW stay onstandard, to help future maintainers understand the mixed-default rationale. - Double-check that the keys in
DEFAULT_ONNX_MODEL_VERSION(azur_lane,cn, etc.) exactly match the logical model identifiers used whenautois resolved; if any naming diverges, it could silently fall back to unintended defaults.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a brief inline comment near `DEFAULT_ONNX_MODEL_VERSION` explaining why English/Azur Lane and Simplified Chinese default to legacy models while JP/TW stay on `standard`, to help future maintainers understand the mixed-default rationale.
- Double-check that the keys in `DEFAULT_ONNX_MODEL_VERSION` (`azur_lane`, `cn`, etc.) exactly match the logical model identifiers used when `auto` is resolved; if any naming diverges, it could silently fall back to unintended defaults.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
恢复特定语言的旧版模型推荐,用于自动 OCR 识别。
Bug Fixes:
Enhancements:
Original summary in English
Summary by Sourcery
Restore language-specific legacy model recommendations for automatic OCR recognition.
Bug Fixes:
Enhancements: