修复非自律寻敌模式下不检查潜艇职能的问题 - #790
Closed
oloadCloud wants to merge 2 commits into
Closed
Conversation
CI 检查报告
检查结果
导入冒烟测试
|
审阅者指南（在小型 PR 上折叠）审阅者指南调整自动搜索处理逻辑：在“清理模式”下提前返回；在“非自动搜索模式”下仅在启用潜艇功能时继续执行，从而修复在非自动敌人搜索配置中缺失的潜艇检查问题。 更新后的 handle_auto_search_setting 逻辑流程图flowchart TD
A[handle_auto_search_setting] --> B[check map_is_clear_mode]
B -->|False| C[return False]
B -->|True| D[check map_is_auto_search]
D -->|True| E[logger.info 自动搜索设置]
D -->|False| F[check config.SUBMARINE]
F -->|False| C
F -->|True| E
文件级变更
可能关联的问题
技巧与命令与 Sourcery 交互
自定义你的体验访问你的 dashboard 以：
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the auto-search handling logic so that in clear mode it returns early, and in non-auto-search mode it only proceeds when submarine functionality is enabled, fixing missing submarine checks in non-autonomous enemy search configuration. Flow diagram for updated handle_auto_search_setting logicflowchart TD
A[handle_auto_search_setting] --> B[check map_is_clear_mode]
B -->|False| C[return False]
B -->|True| D[check map_is_auto_search]
D -->|True| E[logger.info 自动搜索设置]
D -->|False| F[check config.SUBMARINE]
F -->|False| C
F -->|True| E
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - 我在这里提供了一些整体反馈：
- 新增的在
not self.map_is_clear_mode条件下的提前返回改变了非清图模式下的行为；建议重新组织这个条件（例如和map_is_auto_search/SUBMARINE的检查合并），或者加一条简短的内联注释，让后续读代码的人更容易理解预期的控制流程。
给 AI Agent 的提示
请根据这次代码评审中的评论进行修改：
## 整体评论
- 新增的在 `not self.map_is_clear_mode` 条件下的提前返回改变了非清图模式下的行为；建议重新组织这个条件（例如和 `map_is_auto_search`/`SUBMARINE` 的检查合并），或者加一条简短的内联注释，让后续读代码的人更容易理解预期的控制流程。帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈改进后续的评审。
Original comment in English
Hey - I've left some high level feedback:
- The new early return on
not self.map_is_clear_modechanges the behavior for non-clear maps; consider restructuring the condition (e.g., combining it with themap_is_auto_search/SUBMARINEchecks) or adding a brief inline comment to make the intended control flow clearer to future readers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new early return on `not self.map_is_clear_mode` changes the behavior for non-clear maps; consider restructuring the condition (e.g., combining it with the `map_is_auto_search`/`SUBMARINE` checks) or adding a brief inline comment to make the intended control flow clearer to future readers.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Owner
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey - 我在这里给出一些总体反馈：
- 针对
not self.map_is_clear_mode新增的提前返回会改变非清图（non-clear maps）的行为；建议确认这个处理器在这些情况下确实不会被调用，或者添加注释解释为什么在这里必须进行短路返回。 - 条件
if not self.map_is_auto_search and not self.config.SUBMARINE有点不直观；可以考虑重构或补充注释来澄清意图（例如说明潜艇模式在自动搜索关闭时仍然允许继续执行）。
面向 AI Agent 的提示
Please address the comments from this code review:
## Overall Comments
- The new early return on `not self.map_is_clear_mode` changes behavior for non-clear maps; consider confirming this handler is never expected to run in those cases or add a comment explaining why it must short-circuit there.
- The condition `if not self.map_is_auto_search and not self.config.SUBMARINE` is a bit counterintuitive; consider refactoring or commenting to make the intent clear (e.g., that submarine mode allows proceeding even when auto search is off).帮我变得更有用！请在每条评论上点击 👍 或 👎，我会根据你的反馈改进后续代码审查。
Original comment in English
Hey - I've left some high level feedback:
- The new early return on
not self.map_is_clear_modechanges behavior for non-clear maps; consider confirming this handler is never expected to run in those cases or add a comment explaining why it must short-circuit there. - The condition
if not self.map_is_auto_search and not self.config.SUBMARINEis a bit counterintuitive; consider refactoring or commenting to make the intent clear (e.g., that submarine mode allows proceeding even when auto search is off).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new early return on `not self.map_is_clear_mode` changes behavior for non-clear maps; consider confirming this handler is never expected to run in those cases or add a comment explaining why it must short-circuit there.
- The condition `if not self.map_is_auto_search and not self.config.SUBMARINE` is a bit counterintuitive; consider refactoring or commenting to make the intent clear (e.g., that submarine mode allows proceeding even when auto search is off).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Repository owner
deleted a comment from
Beatrice-betty
Aug 19, 2026
Owner
|
请进行足够的测试以表明此修改不会影响现有功能 而且此issue为功能请求 不是bug修复 请测试功能是否正确 同时通过sourcery-ai的审查 |
Author
|
因为不使用自律寻敌，所以不检查职能，导致职能不按用户配置勾选→潜艇意外每战出击，这确实浪费了石油，对用户造成影响，从这点来说我认为这算是BUG，官源也是这个问题。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144
Summary by Sourcery
Bug Fixes:
Original summary in English
Summary by Sourcery
Bug Fixes:
Original summary in English
Summary by Sourcery
Bug Fixes:
Original summary in English
Summary by Sourcery
Bug Fixes:
Original summary in English
Summary by Sourcery
Bug Fixes:
Original summary in English
Summary by Sourcery
Bug Fixes:
Original summary in English
Summary by Sourcery
Bug Fixes:
Original summary in English
Summary by Sourcery
Bug Fixes: