refactor: convert to a Cargo workspace - #1
Merged
Conversation
Owner
Author
|
@claude Review please |
Move the crate from the repository root into crates/maxbin-rs/ and add a virtual workspace manifest at the root. Pure relocation: the binary, its behavior, and its outputs are unchanged. Three adjustments follow from the move: - [profile.bench] moves to the root manifest, since Cargo only honors profiles at the workspace root. - build.rs reads the FFI patch from vendor/maxbin2-cpp-ffi.patch rather than nix/, so it resolves relative to the crate, not the repo root. - references to the moved files are updated to crates/maxbin-rs/: the flake (flake.nix, nix/tests.nix) for the integration test scripts, and CLAUDE.md for the test-script and source-file paths.
werner291
force-pushed
the
refactor/workspace-layout
branch
from
June 1, 2026 13:55
91c078a to
09401a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relocates the crate into a
crates/maxbin-rs/workspace member and adds a virtual workspace manifest at the repository root. Pure relocation: same binary, same outputs, no behavior change.What moved:
src/,tests/,build.rs,vendor/→crates/maxbin-rs/crates/maxbin-rs/vendor/maxbin2-cpp-ffi.patch, with the matchingbuild.rspath updated[profile.bench]→ the root manifest (Cargo only honors profiles at the workspace root)flake.nixandnix/tests.nixreference the moved integration test scripts at their new path.