Open
Conversation
alt-romes
force-pushed
the
ghc-debugger-259
branch
2 times, most recently
from
ec5cd17 to
593863c
Compare
Collaborator
Author
|
TODO We don't get the external interpreter PID directly, we just get the |
Collaborator
Author
|
here's an idea though, I could exchange a message before starting the external interpreter which sends the PID over the socket |
When using the external interpreter, we don't need to use the `hdb proxy` between the user and the debugger/debuggee process. When using the external interpreter, the debuggee process is already launched in a separate process -- simply attach that process to the user's terminal with `runInTerminal`. We still need the proxy case for when the debugger is run with --internal-interpreter, since then we do need to proxy the user's input to the debugger+debuggee shared process. Refactors the proxy/new external-interpreter connection to be per-session rather than being a shared mutable variable across *all* server threads. (Important for future where a single server can serve many debugging sessions e.g. on a remote build server) Additionally refactors how the runInTerminal setup is abstracted, see the haddocks in 'RunInTerminalProc'. Fixes #259
alt-romes
force-pushed
the
ghc-debugger-259
branch
from
d9fe0c4 to
28b8059
Compare
…nInTerminal before initalized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.