Conversation
Collaborator
|
Let me know once I should take a look @Saizan |
Saizan
force-pushed
the
issue257
branch
2 times, most recently
from
b156bfb to
39aeb5b
Compare
* the proxy server thread is part of the call to registerNewDebugSession * we use withAsync for the connection handler thread so it gets killed when parent is.
runGhc has no business messing with them.
alt-romes
approved these changes
Apr 7, 2026
Collaborator
alt-romes
left a comment
alt-romes
left a comment
There was a problem hiding this comment.
Essentially perfect.
The only thing I don't understand is WHY does T130b not trigger on your branches?!!!
Collaborator
|
Land it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to let a user connect and run a debug session multiple times from the same project, while not leaking threads.
TODOs:
[ ] Should this be behind a flag?Things seem to work fine without[ ] call registerNewDebugSession fromNo sessionId yet.initializehandler already?