Look through newtypes for instance mthd argument#248
Closed
Look through newtypes for instance mthd argument#248
Conversation
alt-romes
force-pushed
the
wip/romes/234b
branch
from
5ec7740 to
35d3b1e
Compare
If we find a DebugView instance at runtime, we want to apply it to some (possibly foreign) heap value. Previously, we forgot to look through newtypes when searching for the argument to the instance methods. Fixes #234
This is a regression test for #234, where DebugView instances for newtype constructors don't work. These duplicate T130c, but use a `newtype` instead of `data`.
alt-romes
force-pushed
the
wip/romes/234b
branch
from
35d3b1e to
1bff0b6
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we find a DebugView instance at runtime, we want to apply it to some
(possibly foreign) heap value. Previously, we forgot to look through
newtypes when searching for the argument to the instance methods.
Fixes #234
(Plus a few tests)