Skip to content

Upgrade to GHC 9.14 - #378

Merged
dcoutts merged 4 commits into
well-typed:masterfrom
dancewithheart:ghc-9-14
May 13, 2026
Merged

Upgrade to GHC 9.14#378
dcoutts merged 4 commits into
well-typed:masterfrom
dancewithheart:ghc-9-14

Conversation

@dancewithheart

@dancewithheart dancewithheart commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix #373

Tested locally:

cabal build all
cabal test all
cabal build all -w ghc-9.14.1

@dancewithheart dancewithheart mentioned this pull request May 13, 2026
Closed
dcoutts
dcoutts reviewed May 13, 2026
View reviewed changes

@dcoutts dcoutts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one query. I'll try seeing if we can avoid the bignum change.

Comment thread cborg/cborg.cabal
if flag(optimize-gmp)
cpp-options: -DOPTIMIZE_GMP
if impl(ghc >= 9.0)
if impl(ghc >= 9.0 && < 9.14)

@dcoutts dcoutts May 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this bit about? Why can't we use ghc-bignum with ghc-9.14?

@dcoutts dcoutts May 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've built it and I see the problem. But the fix should be different. I've made a fix and I'll merge with that extra patch.

@dancewithheart dancewithheart May 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this. I was just following the errors.

BTW I really enjoyed your talks about performance and Cardano 🙂

@dcoutts
dcoutts merged commit 2f44ab6 into well-typed:master May 13, 2026
14 of 16 checks passed
@dcoutts

dcoutts commented May 13, 2026

Copy link
Copy Markdown
Member

Thanks @dancewithheart !

@dcoutts dcoutts mentioned this pull request May 13, 2026
Closed
@dancewithheart dancewithheart mentioned this pull request May 14, 2026
Closed
@ysangkok ysangkok mentioned this pull request Jul 21, 2026
Open
@andreasabel

andreasabel commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

It seems that bumping time has been forgotten.

Base package version mismatch is caught by Haskell CI, which is consequently broken atm.
@dancewithheart @dcoutts The failure of CI should maybe have been taken seriously: https://github.com/well-typed/cborg/actions/runs/25780222867/job/75801264002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcoutts dcoutts dcoutts left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Relax upper bounds for GHC 9.14.1

3 participants

@dancewithheart @dcoutts @andreasabel