Conversation
change webui to nightly; fix workflows
fix workflows
It's not missing, but it gets removed from the C library, if |
Hmm, but I still see the following in nightly branch. Nim essentially compiles webui.c together with other transpiled c files. If webui.c still references _webui_win32_wv2_set_url, _webui_win32_wv2_set_stop, linker will fail. Did you try the c lib under windows? I don't see any results in https://github.com/webui-dev/webui/actions/workflows/windows.yml yet. #ifdef _WIN32
if (win->webView->cpp_handle) {
wchar_t* wURL = NULL;
_webui_str_to_wide(url, &wURL);
_webui_win32_wv2_set_url(win->webView->cpp_handle, wURL);
_webui_win32_wv2_set_navigate_flag(win->webView->cpp_handle, true);
_webui_webview_update(win);
}
#else
_webui_free_mem((void*) win->webView->url);
char* url_cp = _webui_str_dup(url);
win->webView->url = url_cp;
win->webView->navigate = true;
_webui_webview_update(win);
#endif #ifdef _WIN32
if (_webui.wins[i]->webView->cpp_handle) {
_webui_win32_wv2_set_stop(_webui.wins[i]->webView->cpp_handle, true);
_webui_webview_update(_webui.wins[i]);
}
#else
_webui.wins[i]->webView->stop = true;
_webui_webview_update(_webui.wins[i]);
#endif |
|
The linker error is for windows and macos: https://github.com/YesDrX/nim-webui/actions/runs/20085517598/job/57621991373 |
Mostly change from "jiro4989/setup-nim-action@v1" to "jiro4989/setup-nim-action@v2'. Also, "nimble install c2nim -y".
I tried to upgrade webui submodule to nightly, but it won't compile as the c library is missing implemenation for _win32_wv2_set_stop under windows and some other similar function in macos.
Actions results:
https://github.com/YesDrX/nim-webui/actions/runs/20046752333
@AlbertShown pls review