fix Card not re-render if state change on parent#89
fix Card not re-render if state change on parent#89iyansr wants to merge 1 commit intowebraptor:masterfrom
Conversation
|
@webraptor Hi, i made some changes related to #85. can you please merge and release asap? thank you |
webraptor
left a comment
webraptor
left a comment
There was a problem hiding this comment.
Can't see how this helps. Please provide extra info on the change, testing etc.
| !isEqual(props.cards, nextProps.cards) || | ||
| props.cardIndex !== nextProps.cardIndex | ||
| props.cardIndex !== nextProps.cardIndex || | ||
| props.renderCard !== nextProps.renderCard |
There was a problem hiding this comment.
@iyansr how does comparing the renderCard function help? I'm pretty sure it will not work or improve the swiper in any way, at least not without introducing a lot of other issues for other people.
|
@iyansr Thanks this code worked for me. I am using this deck swiper to render questions. and my requirement was, whenever the user tap on the card user should view their answer on the card, This could happen because of your code. I added your code in node_modules directly. |
|
glad it helps @hmdrx ! |
|
@webraptor seems like someone have similar problem :D |
|
Thank you and it works @iyansr |
4 participants
Related: #85