Skip to content

fix(url): normalize the Options link - #223

Merged
avivkeller merged 2 commits into
mainfrom
fix/sidebar-options-link
Jul 29, 2026
Merged

fix(url): normalize the Options link#223
avivkeller merged 2 commits into
mainfrom
fix/sidebar-options-link

Conversation

@ryzrr

@ryzrr ryzrr commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary
Uses the already present helper introduced by @moshams272 to normalize the link, so that highlighting can be done in the sidebar

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
no

Does this PR introduce a breaking change?
no

If relevant, what needs to be documented once your changes are merged or what have you already documented?
no

Use of AI
no

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-doc-kit Ready Ready Preview, Comment Jul 28, 2026 8:12pm

Request Review

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

⚡ Lighthouse report

Audited the Vercel preview deployment: https://webpack-doc-yvy36yo9n-openjs.vercel.app

URL Performance Accessibility Best Practices SEO Report
/ 🟢 98 🟢 96 🟢 96 🟢 100 🔗
/about 🟢 99 🟢 97 🟢 100 🟢 100 🔗
/about/sponsors 🟢 99 🟢 95 🟢 96 🟢 100 🔗
/blog 🟢 99 🟢 96 🟢 100 🟢 100 🔗
/blog/posts/2026-02-04-roadmap-2026 🟢 98 🟢 93 🟢 100 🟢 100 🔗
/guides/getting-started 🟢 94 🟢 97 🟢 100 🟢 100 🔗
/docs/api/v5.x/options 🔴 68 🟢 96 🟢 100 🟢 100 🔗
/docs/loaders/css-loader 🟢 98 🟢 97 🟢 100 🟠 83 🔗

Scores are advisory (warn at 90); they do not fail the build. See .lighthouserc.json.

@moshams272

Copy link
Copy Markdown
Contributor

Found another one. BTW, nice catch, bro.

@avivkeller
avivkeller merged commit 7d9d211 into main Jul 29, 2026
11 checks passed
@ryzrr
ryzrr deleted the fix/sidebar-options-link branch July 29, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants