Skip to content

chore: github stuff - #209

Merged
avivkeller merged 3 commits into
mainfrom
github
Jul 29, 2026
Merged

chore: github stuff#209
avivkeller merged 3 commits into
mainfrom
github

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Adds stuff to improve the GitHub UI including:

  • Issue templates
  • Contributing
  • Dependabot Setup
  • License

Copilot AI review requested due to automatic review settings July 22, 2026 05:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-doc-kit Ready Ready Preview, Comment Jul 29, 2026 4:16am

Request Review

Comment thread .github/dependabot.yml
@@ -0,0 +1,26 @@
version: 2
updates:
- package-ecosystem: npm
Comment thread .github/dependabot.yml
- minor
- patch

- package-ecosystem: github-actions
Comment thread LICENSE Outdated
@github-actions

Copy link
Copy Markdown
Contributor

⚡ Lighthouse report

Audited the Vercel preview deployment: https://webpack-doc-ebwb68a7i-openjs.vercel.app

URL Performance Accessibility Best Practices SEO Report
/ 🟢 98 🟢 96 🟢 96 🟢 100 🔗
/about 🟢 99 🟢 97 🟢 100 🟢 100 🔗
/about/sponsors 🟢 99 🟢 95 🟢 96 🟢 100 🔗
/blog 🟢 99 🟢 96 🟢 100 🟢 100 🔗
/blog/posts/2026-02-04-roadmap-2026 🟢 98 🟢 93 🟢 100 🟢 100 🔗
/guides/getting-started 🟢 94 🟢 97 🟢 100 🟢 100 🔗
/docs/api/v5.x/options 🔴 68 🟢 96 🟢 100 🟢 100 🔗
/docs/loaders/css-loader 🟢 98 🟢 97 🟢 100 🟠 83 🔗

Scores are advisory (warn at 90); they do not fail the build. See .lighthouserc.json.

@avivkeller
avivkeller requested a review from bjohansebas July 22, 2026 17:50
Co-authored-by: Sebastian Beltran <bjohansebas@gmail.com>
Copilot AI review requested due to automatic review settings July 22, 2026 18:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Comment thread README.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md
Comment on lines +49 to +53
In the above example, `npm run build` runs the whole pipeline (it downloads the webpack releases in `versions.json` and generates their API docs), so it takes a few minutes. After that, if you are only editing hand-written pages, regenerate just the HTML:

```sh
npm run build:html
```

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to preview changes live when I'm only editing a single page, without having to rebuild the entire site?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now there is not.
should this feature be at doc-kit side or here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probabily doc-kit

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not doc kit, here, I think. Some sort of --watch system, right?

eg look at the diff and only build changed pages + watch

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I feel like that's more of a responsibility for doc-kit than for this project, though. I mean, why would we have our own watch system?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's in doc-kit, doc-kit doesn't check if output has changed since it's last build, it just takes the input and produces output. It's on the consumer to determine what inputs to pass to doc-kit (IMO)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However you prefer. I'm not the maintainer of doc-kit, this is just feedback.

One thing that tends to characterize documentation tooling is making the development experience as smooth as possible. A big reason people adopt these tools is because they provide a good DX for writing and maintaining docs. 🙂

For example, in Express we have contributors who aren't developers at all. They focus entirely on the documentation because they're good at writing and organizing it. They don't really care about implementation details—they just want to run a single command, have the site start, and see their changes immediately.

This project is a bit different since everyone here is a developer, so it's less of a concern. And as a last resort, we'll always have Vercel previews to verify the changes. 🙂

@avivkeller avivkeller linked an issue Jul 23, 2026 that may be closed by this pull request
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
Comment thread LICENSE
Co-authored-by: Sebastian Beltran <bjohansebas@gmail.com>
@avivkeller
avivkeller merged commit 2c86e93 into main Jul 29, 2026
10 checks passed
@bjohansebas
bjohansebas deleted the github branch July 29, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve contributing docs

7 participants