Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/use-webpack-infrastructure-logger.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"webpack-bundle-analyzer": minor
---

Use Webpack's infrastructure logger when available (`compiler.getInfrastructureLogger('webpack-bundle-analyzer')`) and deprecate the plugin's `logLevel` option in favor of Webpack's native `infrastructureLogging` configuration.
30 changes: 4 additions & 26 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

61 changes: 55 additions & 6 deletions test/plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,22 +144,71 @@ describe("Plugin", () => {

try {
await webpackCompile(config);

const server = await plugin.server;
expect(server.http.listening).toBe(true);
expect(analyzerUrl).toHaveBeenCalledWith(
expect.objectContaining({
listenHost: "127.0.0.1",
listenPort: 0,
boundAddress: expect.objectContaining({
address: "127.0.0.1",
port: expect.any(Number),
}),
}),
);
} finally {
if (plugin.server) {
const server = await plugin.server;
server.ws.close();
await new Promise((resolve) => {
server.http.close(() => resolve());
});
try {
const server = await plugin.server;
server.ws.close();
await new Promise((resolve) => {
server.http.close(resolve);
});
} catch {
// Ignore server cleanup error
}
}
}
});

it("should update chart data when a plugin instance is reused in server mode", async () => {
const plugin = new BundleAnalyzerPlugin({
analyzerMode: "server",
analyzerPort: "auto",
openAnalyzer: false,
logLevel: "error",
});
const firstConfig = makeWebpackConfig();
const secondConfig = makeWebpackConfig();

firstConfig.output.path = path.resolve(__dirname, "./output/first");
firstConfig.plugins = [plugin];
secondConfig.output.path = path.resolve(__dirname, "./output/second");
secondConfig.plugins = [plugin];

try {
await webpackCompile(firstConfig);
const server = await plugin.server;
const updateChartDataSpy = jest.spyOn(server, "updateChartData");

await webpackCompile(secondConfig);

expect(updateChartDataSpy).toHaveBeenCalledTimes(1);
expect(updateChartDataSpy).toHaveBeenCalledWith(
expect.any(Object),
path.resolve(__dirname, "./output/second"),
);
} finally {
if (plugin.server) {
try {
const server = await plugin.server;
server.ws.close();
await new Promise((resolve) => {
server.http.close(resolve);
});
} catch {
// Ignore server cleanup error
}
}
}
});
Expand Down
Loading