Skip to content

Add clarifications to Summarizer preference parameter#102

Merged
michaelwasserman merged 2 commits into
webmachinelearning:mainfrom
jaewon078:summarizer-preference-clarifications
Apr 17, 2026
Merged

Add clarifications to Summarizer preference parameter#102
michaelwasserman merged 2 commits into
webmachinelearning:mainfrom
jaewon078:summarizer-preference-clarifications

Conversation

@jaewon078

@jaewon078 jaewon078 commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

💥 Error: 422 Unprocessable Entity 💥

PR Preview failed to build. (Last tried on Apr 17, 2026, 2:08 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build bikeshed/ReSpec specs

🔗 Related URL

Error output:

[
    {
        "lineNum": "2293:91",
        "messageType": "link",
        "text": "Multiple possible 'RangeError' idl refs.\nArbitrarily chose https://tc39.es/ecma262/multipage/fundamental-objects.html#sec-native-error-types-used-in-this-standard-rangeerror\nTo auto-select one of the following refs, insert one of these lines into a <pre class=link-defaults> block:\nspec:ecmascript; type:exception; text:RangeError\nspec:webidl; type:exception; text:RangeError\n{{RangeError}}"
    },
    {
        "lineNum": "631:1",
        "messageType": "lint",
        "text": "RFC2119 keyword in non-normative section (use: might, can, has to, or override with <span class=allow-2119>): When resolving the underlying model, the implementation should prioritize hard functional constraints over the \n<p bs-line-number=\"631:1\" class=\"note\">When resolving the underlying model, the implementation should prioritize hard functional constraints over the <code bs-line-number=\"631:128\">preference</code> hint. For example, if the requested options require specific capabilities (such as a requested language in <code bs-line-number=\"631:259\">expectedInputLanguages</code>) that are only supported by a model that does not align with the requested <code bs-line-number=\"631:370\">preference</code>, the implementation should select the model capable of completing the task.</p>"
    },
    {
        "lineNum": "631:1",
        "messageType": "lint",
        "text": "RFC2119 keyword in non-normative section (use: might, can, has to, or override with <span class=allow-2119>): , the implementation should select the model capable of completing the task.\n<p bs-line-number=\"631:1\" class=\"note\">When resolving the underlying model, the implementation should prioritize hard functional constraints over the <code bs-line-number=\"631:128\">preference</code> hint. For example, if the requested options require specific capabilities (such as a requested language in <code bs-line-number=\"631:259\">expectedInputLanguages</code>) that are only supported by a model that does not align with the requested <code bs-line-number=\"631:370\">preference</code>, the implementation should select the model capable of completing the task.</p>"
    },
    {
        "lineNum": null,
        "messageType": "failure",
        "text": "Did not generate, due to errors exceeding the allowed error level."
    }
]

This seems to be an issue with the Spec Generator service. PR Preview doesn't manage this service and so has no control over it. If you've identified an issue with it, you can report the issue to the maintainers of Spec Generator directly. Please be courteous. Thank you!

If you don't have enough information above to solve the error by yourself or if the issue doesn't seem related to Spec Generator, you can file an issue with PR Preview.

@anssiko anssiko added the Agenda+ label Apr 7, 2026

@michaelwasserman michaelwasserman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a minor comment and a thought for follow-up.

Before merging, let's request input from WebML CG folks and give them a little time to respond, since they were curious about this topic and the preceding work that added the initial experimental enhancements.

Comment thread explainers/summarizer-preference-param.md Outdated
Comment thread explainers/summarizer-preference-param.md
@anssiko

anssiko commented Apr 16, 2026

Copy link
Copy Markdown
Member

RESOLUTION: Add clarifications to Summarizer preference parameter per PR #102.

@anssiko anssiko removed the Agenda+ label Apr 16, 2026
@anssiko

anssiko commented Apr 17, 2026

Copy link
Copy Markdown
Member

@jaewon078 thank you!

@michaelwasserman to merge.

@michaelwasserman

Copy link
Copy Markdown
Collaborator

Looks great, thanks @jaewon078 and ty @anssiko for review!

@michaelwasserman michaelwasserman merged commit ca32112 into webmachinelearning:main Apr 17, 2026
2 checks passed
github-actions Bot added a commit that referenced this pull request Apr 17, 2026
SHA: ca32112
Reason: push, by michaelwasserman

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants