Add clarifications to Summarizer preference parameter#102
Merged
michaelwasserman merged 2 commits intoApr 17, 2026
Merged
Conversation
michaelwasserman
approved these changes
Apr 8, 2026
michaelwasserman
left a comment
Collaborator
There was a problem hiding this comment.
lgtm with a minor comment and a thought for follow-up.
Before merging, let's request input from WebML CG folks and give them a little time to respond, since they were curious about this topic and the preceding work that added the initial experimental enhancements.
Member
|
anssiko
approved these changes
Apr 16, 2026
Member
|
@jaewon078 thank you! @michaelwasserman to merge. |
Collaborator
|
Looks great, thanks @jaewon078 and ty @anssiko for review! |
github-actions Bot
added a commit
that referenced
this pull request
Apr 17, 2026
SHA: ca32112 Reason: push, by michaelwasserman Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💥 Error: 422 Unprocessable Entity 💥
PR Preview failed to build. (Last tried on Apr 17, 2026, 2:08 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build bikeshed/ReSpec specs
🔗 Related URL
Error output:
[ { "lineNum": "2293:91", "messageType": "link", "text": "Multiple possible 'RangeError' idl refs.\nArbitrarily chose https://tc39.es/ecma262/multipage/fundamental-objects.html#sec-native-error-types-used-in-this-standard-rangeerror\nTo auto-select one of the following refs, insert one of these lines into a <pre class=link-defaults> block:\nspec:ecmascript; type:exception; text:RangeError\nspec:webidl; type:exception; text:RangeError\n{{RangeError}}" }, { "lineNum": "631:1", "messageType": "lint", "text": "RFC2119 keyword in non-normative section (use: might, can, has to, or override with <span class=allow-2119>): When resolving the underlying model, the implementation should prioritize hard functional constraints over the \n<p bs-line-number=\"631:1\" class=\"note\">When resolving the underlying model, the implementation should prioritize hard functional constraints over the <code bs-line-number=\"631:128\">preference</code> hint. For example, if the requested options require specific capabilities (such as a requested language in <code bs-line-number=\"631:259\">expectedInputLanguages</code>) that are only supported by a model that does not align with the requested <code bs-line-number=\"631:370\">preference</code>, the implementation should select the model capable of completing the task.</p>" }, { "lineNum": "631:1", "messageType": "lint", "text": "RFC2119 keyword in non-normative section (use: might, can, has to, or override with <span class=allow-2119>): , the implementation should select the model capable of completing the task.\n<p bs-line-number=\"631:1\" class=\"note\">When resolving the underlying model, the implementation should prioritize hard functional constraints over the <code bs-line-number=\"631:128\">preference</code> hint. For example, if the requested options require specific capabilities (such as a requested language in <code bs-line-number=\"631:259\">expectedInputLanguages</code>) that are only supported by a model that does not align with the requested <code bs-line-number=\"631:370\">preference</code>, the implementation should select the model capable of completing the task.</p>" }, { "lineNum": null, "messageType": "failure", "text": "Did not generate, due to errors exceeding the allowed error level." } ]This seems to be an issue with the Spec Generator service. PR Preview doesn't manage this service and so has no control over it. If you've identified an issue with it, you can report the issue to the maintainers of Spec Generator directly. Please be courteous. Thank you!
If you don't have enough information above to solve the error by yourself or if the issue doesn't seem related to Spec Generator, you can file an issue with PR Preview.