Treat empty string as None in _todate/_totime/_todatetime filter_in#760
Open
nursix wants to merge 1 commit intoweb2py:masterfrom
Open
Treat empty string as None in _todate/_totime/_todatetime filter_in#760nursix wants to merge 1 commit intoweb2py:masterfrom
nursix wants to merge 1 commit intoweb2py:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the standard filter_in methods for date/time/datetime fields would crash for empty strings (AssertionError).
This fix catches empty strings, and treats them as None-equivalent (i.e. NULL).
One could consider to pass an empty string as-is, but this seems invalid as parsers expect either NULL or a valid date/time string for these field types - and even if parsers could handle empty strings for date/time, surely they would return None (what else?), which makes them equivalent to NULL on a round-trip. Hence, returning None for both None and "" seems correct for these particular filter_in methods.