Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the default for a datetime field to datetime.datetime.utcnow (a built-in function) would crash upon insert, due to the mandatory filter_in for that field type.
Either callable defaults are in fact called before filter_in, or filter_in skips them altogether. The difference is that in the former approach, the result of the callable would still be converted with _todatetime, whereas the latter approach simply sends the datetime object for conversion by the representer.
It seems more consistent to also pass the output of a callable through filter_in (note: the output - not the callable, as it were), however, it is a bit confusing why the default _filter_in produces a string for a datetime object if the representer can perfectly handle a datetime object - including the (theoretically dialect-specific) dt_sep?