[Reference Target] Reflect host even if reference target is invalid#60283
Merged
Conversation
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7883837
branch
from
ad0d949 to
935174d
Compare
Currently if a shadow root's reference target doesn't match any ID in the shadow, any element-reflecting IDL attributes (e.g. popoverTargetElement) referring to the shadow host will return null. Recent thinking in [1] and the current state of the spec PR [2] is that these should still reflect the shadow host, same as if the reference target pointed to a matching element. Update the Chromium implementation and tests to match this updated behavior. As it turns out, this also slightly simplifies the implementation. [1] WICG/webcomponents#1114 [2] whatwg/html#10995 Bug: 346835896 Change-Id: Ic321d5dffc1800fc081e9edfbb46524acc63a8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7883837 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1638691}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7883837
branch
from
935174d to
570ffde
Compare
wpt-pr-bot
approved these changes
May 29, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if a shadow root's reference target doesn't match any ID in
the shadow, any element-reflecting IDL attributes (e.g.
popoverTargetElement) referring to the shadow host will return null.
Recent thinking in [1] and the current state of the spec PR [2] is that
these should still reflect the shadow host, same as if the reference
target pointed to a matching element.
Update the Chromium implementation and tests to match this updated
behavior. As it turns out, this also slightly simplifies the
implementation.
[1] WICG/webcomponents#1114
[2] whatwg/html#10995
Bug: 346835896
Change-Id: Ic321d5dffc1800fc081e9edfbb46524acc63a8be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7883837
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1638691}