Revert "QuotaExceededError: Update to a DOMException derived interface"#52571
Merged
Conversation
wpt-pr-bot
requested review from
annevk,
ayuishii,
domenic,
inexorabletash,
jgraham and
yuki3
WeizhongX
requested review from
DanielRyanSmith
and removed request for
annevk,
ayuishii,
domenic,
inexorabletash,
jgraham and
yuki3
Member
|
tl;dr: we shouldn't be changing the behaviour of |
gsnedders
approved these changes
May 15, 2025
DanielRyanSmith
approved these changes
May 15, 2025
Contributor
Author
|
Had a discussion in chromium. Maybe we want to revert chromium's change then wait that to be exported. Let's hold on this for a while. |
Member
|
I mean, we're happy to land the Web IDL PR if that would make things easier, we just thought it'd be better to collect some compat data in Chromium first. But if that's going to cause us to be unable to test the changes, then maybe it's best to just merge it. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 21, 2025
This change updates services that use QuotaExceededError to use the new DOMException derived QuotaExceededError class when the flag is enabled. I've not been allowed to update external wpts until the webidl spec has been updated[0][1], so this change only updates tests for Chrome only wpts, and otherwise updates expectations for the external ones. External wpts will be updated when the webidl spec is merged and I am allowed to update the external wpts (as seen in chained CL). [0] Spec PR: whatwg/webidl#1465 [1] Discussion: web-platform-tests/wpt#52571 (comment) Bug: 406162261 Change-Id: Ie45d6095a3e4c21e21a35d2519d268580b8bc36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6538066 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Daseul Lee <dslee@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463139}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #52556
Per Sam's comment:
With my WPT Core Team hat on, this change to testharness.js absolutely cannot land until whatwg/webidl#1465 does.