DOM: Add slotchange test for moveBefore()#50945
Merged
Merged
Conversation
This CL adds a test to ensure that the 'slotchange' event is fired when slots themselves are moved in and out of a custom element, and their assigned nodes change. This addresses whatwg/dom#1307 (comment). R=nrosenthal Bug: 40150299 Change-Id: I93ee04294e5ab3e6d9f75c48705cdc77ce0a1df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6298941 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1424746}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6298941
branch
from
7a3ceea to
f53cc11
Compare
wpt-pr-bot
approved these changes
Feb 25, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL adds a test to ensure that the 'slotchange' event is fired when
slots themselves are moved in and out of a custom element, and their
assigned nodes change.
This addresses
whatwg/dom#1307 (comment).
R=nrosenthal
Bug: 40150299
Change-Id: I93ee04294e5ab3e6d9f75c48705cdc77ce0a1df3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6298941
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424746}