Update popover post-toggle event naming and behavior#38206
Merged
Conversation
wpt-pr-bot
approved these changes
Jan 26, 2023
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4195120
branch
from
509c4a3 to
5f09d18
Compare
This CL updates the post-toggle event in the following ways:
1. Rename the 'aftertoggle' event to 'toggle'.
2. Rename PopoverToggleEvent to ToggleEvent.
3. Rename the currentState attribute to oldState.
4. Add event coalescing behavior. If two transitions occur before the
first 'toggle' event has been fired, cancel the first event and
queue a replacement that has oldState === newState.
These changes were driven by the corresponding changes to the spec PR:
whatwg/html#8717
Bug: 1307772
Change-Id: Iabc5a9093d7cef3bbd6e54e488d8e571c51ea568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4195120
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1098728}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4195120
branch
from
5f09d18 to
bfc0288
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL updates the post-toggle event in the following ways:
first 'toggle' event has been fired, cancel the first event and
queue a replacement that has oldState === newState.
These changes were driven by the corresponding changes to the spec PR:
whatwg/html#8717
Bug: 1307772
Change-Id: Iabc5a9093d7cef3bbd6e54e488d8e571c51ea568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4195120
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1098728}