Check popover stack when buttons are modified#37594
Merged
Merged
Conversation
wpt-pr-bot
approved these changes
Dec 20, 2022
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
3 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4115790
branch
3 times, most recently
from
345c204 to
e0ab538
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4115790
branch
5 times, most recently
from
de6079c to
555b64a
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4115790
branch
3 times, most recently
from
9472606 to
ae26495
Compare
The popover stack is constructed by attributes set on buttons. When those buttons are modified, it can break connections in the stack. This patch adds checks to spots where buttons can be modified in order to fix up the list by closing all popovers when a connection has been broken. This patch also moves the disabled check for popover*target attributes which Anne asked for here: whatwg/html#8221 (comment) Bug: 1307772, 1408546 Change-Id: I129cf2768abc717292b86ea26f7522019ce36d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4115790 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1096920}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4115790
branch
from
ae26495 to
9d962f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The popover stack is constructed by attributes set on buttons. When
those buttons are modified, it can break connections in the stack. This
patch adds checks to spots where buttons can be modified in order to fix
up the list by closing all popovers when a connection has been broken.
This patch also moves the disabled check for popover*target attributes
which Anne asked for here:
whatwg/html#8221 (comment)
Bug: 1307772, 1408546
Change-Id: I129cf2768abc717292b86ea26f7522019ce36d33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4115790
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1096920}