Update menclose help and explains better how tests work in MathML core#23495
Merged
Conversation
No consensus have been reached on the future on menclose so far but this element has been the source of confusion so the current draft text has been removed from MathML Core and put in a separate pull request: w3c/mathml-core#24 This PR updates the WPT tests accordingly: * Actual tests for menclose are renamed "tentative" and refer to the pull request above, so that it becomes clear they are not definitive yet and browsers are free to ignore them. * Tests for mrow-like are now referring to MathML3 https://www.w3.org/TR/MathML3/chapter3.html#presm.menclose They are still valid because unknown elements are treated as mrow-like in MathML Core. * Tests for removed legacy features are obviously still valid too. Again, the documentation is updated to refer to MathML3 https://www.w3.org/TR/MathML3/chapter3.html#presm.menclose
Collaborator
|
There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
rwlbuis
approved these changes
May 9, 2020
rwlbuis
left a comment
rwlbuis
left a comment
Contributor
There was a problem hiding this comment.
explains better - > explain better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No consensus have been reached on the future on menclose so far but this
element has been the source of confusion so the current draft text has
been removed from MathML Core and put in a separate pull request:
w3c/mathml-core#24
This PR updates the WPT tests accordingly:
Actual tests for menclose are renamed "tentative" and refer to the
pull request above, so that it becomes clear they are not definitive yet
and browsers are free to ignore them.
Tests for mrow-like are now referring to MathML3
https://www.w3.org/TR/MathML3/chapter3.html#presm.menclose
They are still valid because unknown elements are treated as mrow-like
in MathML Core.
Tests for removed legacy features are obviously still valid too.
Again, the documentation is updated to refer to MathML3
https://www.w3.org/TR/MathML3/chapter3.html#presm.menclose