correct default expectation for existing mrow test#22226
Merged
Conversation
Attempting to match defaults defined in whatwg/html#5248 definitely needs scrutiny..
fred-wang
reviewed
Mar 12, 2020
fred-wang
left a comment
fred-wang
left a comment
Contributor
There was a problem hiding this comment.
I guess it would be better to do it in two PR: (1) testing more linkable elements and then (2) change tabindex. Otherwise it's not easy to figure out what's happening when checking the log history.
The default `.tabIndex` of an mrow should be 0 regardless of when it has an href or not, as a linkable element and matching historical (oddity) of other linkable things in HTML/SVG
bkardell
changed the title
fred-wang
approved these changes
Mar 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to match defaults defined in whatwg/html#5248
definitely needs scrutiny..