Skip to content

Make the add-middleware function public#13

Open
jcrossley3 wants to merge 1 commit into
weavejester:masterfrom
jcrossley3:patch-1
Open

Make the add-middleware function public#13
jcrossley3 wants to merge 1 commit into
weavejester:masterfrom
jcrossley3:patch-1

Conversation

@jcrossley3

Copy link
Copy Markdown

I'd love for immutant.web/start to accept the same handy dev-mode
options provided by ring-server, but I'd rather not rewrite the code.
If this function was exposed, I'd be set! :) 

I'd love for immutant.web/start to accept the same handy dev-mode 
options provided by ring-server, but I'd rather not rewrite the code.
If this function was exposed, I'd be set! :) 
@jcrossley3

Copy link
Copy Markdown
Author

I tried using the function as is by referring to its var, only to realize that standalone pulls in ring.adapter.jetty that I really don't need. I'd almost prefer those add-* functions moved to the options ns, or possibly a new one entirely. I'd hate to pull in the jetty dep, but I'd like to re-use the logic for adding the middleware. Are you open to that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant