Skip to content

fix: install jq automatically for router setup - #1638

Merged
steventohme merged 3 commits into
mainfrom
codex/install-jq-automatically
Oct 6, 2026
Merged

steventohme merged 3 commits into
mainfrom
codex/install-jq-automatically

Conversation

@steventohme

Copy link
Copy Markdown
Contributor

Claude Code, opencode, and pi setup currently stop on machines without jq, which is common on fresh macOS and Git Bash installations. The installer now downloads jq 1.8.1 for supported macOS, Linux, and Windows Git Bash architectures, verifies the pinned SHA-256 before installing it under ~/.weave/bin, and makes it available to installed hooks. No package manager or administrator access is needed.

Validation: jq bootstrap regression tests pass for both macOS architectures and simulated Windows Git Bash, including checksum rejection; a real checksum-verified download and JSON invocation succeeded on macOS. Router docs/tooling, Go tests, lint, Claude status, Codex installer, and statusline checks passed. The full installer suite still has a client-events regression failure; OpenCode tests are also limited by the local CLI version (1.18.32 vs the driver's pinned version). Native Windows execution remains to be tested.

@parameterai

parameterai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Risk: No findings

The changes since the last review only touch the jq bootstrap test, install/tests/jq_bootstrap_test.py. The tests now compute a real SHA-256 and use the real shasum/sha256sum, so the checksum-mismatch cases exercise actual verification. I found no security issues in this diff.

Sentinel reviewed c61f3be · Review settings

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Turn on auto-fix | Re-trigger cubic

Comment thread install/tests/jq_bootstrap_test.py
Comment thread install/npm/README.md Outdated
@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Retrigger

[Medium risk] Adds automatic jq download to installer setup scripts.

The findings are non-blocking coverage and cleanup concerns; no blocking defect was established.

Reviews (1) · Last reviewed commit: "fix: install jq automatically for router..."

Comment thread install/tests/jq_bootstrap_test.py
Comment thread install/install.sh
weave-checks[bot]

This comment was marked as resolved.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Turn on auto-fix | Re-trigger cubic

Comment thread install/tests/jq_bootstrap_test.py Outdated
@steventohme
steventohme enabled auto-merge (squash) October 6, 2026 22:44
@steventohme
steventohme merged commit 25a10d8 into main Oct 6, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant