Repository navigation
fix: install jq automatically for router setup - #1638
Conversation
|
Risk: No findings The changes since the last review only touch the jq bootstrap test, Sentinel reviewed |
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Turn on auto-fix | Re-trigger cubic
|
[Medium risk] Adds automatic jq download to installer setup scripts. The findings are non-blocking coverage and cleanup concerns; no blocking defect was established. Reviews (1) · Last reviewed commit: "fix: install jq automatically for router..." |
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Turn on auto-fix | Re-trigger cubic
Claude Code, opencode, and pi setup currently stop on machines without
jq, which is common on fresh macOS and Git Bash installations. The installer now downloads jq 1.8.1 for supported macOS, Linux, and Windows Git Bash architectures, verifies the pinned SHA-256 before installing it under~/.weave/bin, and makes it available to installed hooks. No package manager or administrator access is needed.Validation: jq bootstrap regression tests pass for both macOS architectures and simulated Windows Git Bash, including checksum rejection; a real checksum-verified download and JSON invocation succeeded on macOS. Router docs/tooling, Go tests, lint, Claude status, Codex installer, and statusline checks passed. The full installer suite still has a client-events regression failure; OpenCode tests are also limited by the local CLI version (1.18.32 vs the driver's pinned version). Native Windows execution remains to be tested.