Repository navigation
Add optional files glob to filter check runs - #8
Merged
Merged
Conversation
Co-Authored-By: Weave Router <router@weaveos.com>
Fixed: - Remove diffFilePaths, which had no production callers - Keep diff filtering coverage focused on active behavior Co-Authored-By: Weave Router <router@weaveos.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 30f42a2. Configure here.
Fixed: - Resolve prior findings even when a scoped check has no new matching files - Reject quoted file globs unsupported by the plain-scalar parser Co-Authored-By: Weave Router <router@weaveos.com>
|
[Medium risk] Adds optional file-glob filtering to check execution. Not safe to merge as written: the file-scope boundary can be bypassed, and matching changes can receive passing results without evaluation. Reviews (1) · Last reviewed commit: "Add optional files glob to filter check ..." · Reviewed by Greptile |
Fixed: - Ignore header-like content inside diff hunks when parsing file paths - Preserve directory prefixes in rename metadata - Clarify the judge invocation test variable name Co-Authored-By: Weave Router <router@weaveos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
filesglob frontmatter to scope check execution and review diffsVerification
npm test(420 tests pass)npm run format:checkgit diff --check🤖 Generated with Weave Router