Skip to content

Add optional files glob to filter check runs - #8

Merged
a-churchill merged 4 commits into
mainfrom
andrew/check-file-globs
Oct 7, 2026
Merged

a-churchill merged 4 commits into
mainfrom
andrew/check-file-globs

Conversation

@a-churchill

Copy link
Copy Markdown
Contributor

Summary

  • Add optional files glob frontmatter to scope check execution and review diffs
  • Disable repository-reading, shell, and MCP tools for scoped checks so they cannot inspect out-of-scope files
  • Document glob syntax and cover filtering, skips, and diff scoping with tests

Verification

  • npm test (420 tests pass)
  • npm run format:check
  • git diff --check

🤖 Generated with Weave Router

Co-Authored-By: Weave Router <router@weaveos.com>
weave-checks[bot]

This comment was marked as resolved.

Fixed:
- Remove diffFilePaths, which had no production callers
- Keep diff filtering coverage focused on active behavior

Co-Authored-By: Weave Router <router@weaveos.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 30f42a2. Configure here.

Comment thread src/worker.mjs
Comment thread src/parse.mjs Outdated
Fixed:
- Resolve prior findings even when a scoped check has no new matching files
- Reject quoted file globs unsupported by the plain-scalar parser

Co-Authored-By: Weave Router <router@weaveos.com>
weave-checks[bot]

This comment was marked as resolved.

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Retrigger

[Medium risk] Adds optional file-glob filtering to check execution.

Not safe to merge as written: the file-scope boundary can be bypassed, and matching changes can receive passing results without evaluation.

Reviews (1) · Last reviewed commit: "Add optional files glob to filter check ..." · Reviewed by Greptile

Comment thread src/file-glob.mjs Outdated
Comment thread src/parse.mjs Outdated
Comment thread src/file-glob.mjs Outdated
Fixed:
- Ignore header-like content inside diff hunks when parsing file paths
- Preserve directory prefixes in rename metadata
- Clarify the judge invocation test variable name

Co-Authored-By: Weave Router <router@weaveos.com>
@a-churchill
a-churchill merged commit aebe29a into main Oct 7, 2026
19 checks passed
@a-churchill
a-churchill deleted the andrew/check-file-globs branch October 7, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant