Only fail aggregate run on infrastructure error

[a-churchill]

Summary

• Fail the aggregate check only for infrastructure errors.
• Keep malformed/unusable model output and rejected review payloads neutral, and include their cause in the result JSON.
• Preserve the reviewed-marker guard so incomplete output is reconsidered on the next run.

Verification

• npm run format
• npm test (408 tests passed)

🤖 Generated with Weave Router

[greptile-apps]

[Medium risk] Changes how check failures are classified and reported.

Not safe to merge: an operational review rejection can leave a required check neutral even though the review was not posted.

_{Reviews (1) · Last reviewed commit: "Only fail aggregate run on infrastructur..."}

[greptile-apps]

Comments Outside Diff

These findings could not be posted inline.

•  Zero-review aggregate can satisfy a required check ▶

  • Bug
    • For a nonempty review diff with no configured checks, the worker publishes a completed neutral aggregate and a completed output marker without reviewing anything. A required GitHub check with a neutral conclusion does not itself block merging.
  • Cause
    • In src/worker.mjs:1029-1037, all.some(...) is false for an empty state list, while the success condition requires all.length > 0; the remaining branch selects NEUTRAL. everyCheckReviewed([]) correctly prevents the reviewed marker but does not affect the conclusion.
  • Fix
    • Treat an empty check-state list with a nonempty DIFF as a failure or explicit configuration error before finalizing the aggregate.