Skip to content

Fix query validation and enhance file download functionality#2

Open
ikido wants to merge 13 commits into
mainfrom
feature/query-fixes-and-file-handling
Open

Fix query validation and enhance file download functionality#2
ikido wants to merge 13 commits into
mainfrom
feature/query-fixes-and-file-handling

Conversation

@ikido

@ikido ikido commented Aug 11, 2025

Copy link
Copy Markdown

Summary

  • Fix q_where schema validation from object to array to support Fibery query syntax
  • Add support for inline files in download_attachments tool with file_secrets parameter
  • Fix NoneType error in query tool when field doesn't exist in schema
  • Update tool descriptions and parameter validation

Changes Made

Query Tool Fixes

  • Fixed q_where parameter schema validation to accept arrays instead of objects
  • Added null check in get_rich_text_fields() to handle missing fields gracefully
  • Prevents crashes when querying with non-existent field names

File Download Enhancements

  • Added support for inline files using file_secrets parameter
  • Implemented HTTP client logic to follow redirects for file downloads
  • Enhanced tool to work in two modes: attachment mode and inline file mode
  • Updated tool schema and descriptions to reflect new capabilities

Test Plan

  • Query tool now accepts proper Fibery array syntax for where clauses
  • Query tool handles missing fields without crashing
  • Download attachments tool supports both attachment and inline file modes
  • Code passes linting and formatting checks

maxdubakov and others added 13 commits April 17, 2025 09:19
Deployment: Dockerfile and Smithery config and update README.md
- New tool to get download URLs for entity attachments
- Supports filtering by attachment name or ID
- Returns structured data with download links and curl commands
- Follows existing tool patterns and conventions

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Replace Files/Name with fibery/name in file queries to match Fibery schema.
The Files/Name field doesn't exist in fibery/file database - the correct field is fibery/name.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Fix q_where schema validation from object to array to support Fibery query syntax
- Add support for inline files in download_attachments tool with file_secrets parameter
- Fix NoneType error in query tool when field doesn't exist in schema
- Update tool descriptions and parameter validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants