Open
Conversation
nelsonamaya82
requested review from
Fcog,
adamf321,
arzola,
bethshook,
honekun and
mannuel
adamf321
reviewed
Jun 11, 2020
|
|
||
| $close_pos = strpos( $block_content, '>' ); | ||
| $data_type_pos = strpos( $block_content, 'data-type' ); | ||
| if ( false !== $close_pos && false === $data_type_pos ) { |
Member
There was a problem hiding this comment.
I think you could have simply kept it as was and changed the if as follows:
if ( false !== $close_pos && ( false === $data_type_pos || $data_type_pos > $close_pos ) ) {
Contributor
Author
There was a problem hiding this comment.
I initially considered that solution, but I think it's more performant to search for the data-type attribute just in the opening tag of the block instead of the whole block content (e.g. if the block had a lot of content and just at the end an element with this data attribute).
adamf321
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I added some extra validations to the methods that add properties to some Gutenberg blocks to make sure the properties are added/modified in the block opening part only, instead of any part of the block content.
It also fixes a bug in the
lean_column_propsmethod that removed any attribute with thestyle=substring in the block content, e.g.data-style=(and not only thestyleattribute, as expected).