Skip to content

Add role/permission-based authorization for bulk-delete Brains endpoint (DELETE /web/brains/deleteall) #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SinghCod3r wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add role/permission-based authorization for bulk-delete Brains endpoint (DELETE /web/brains/deleteall) #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion nodejs/src/controller/web/brainController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,15 @@ const deleteBrain = catchAsync(async (req, res) => {
return util.failureResponse(_localize('module.deleteError', req, BRAIN), res);
})

const { ROLE_TYPE } = require('../../config/constants/common');

const deleteAllBrain = catchAsync(async (req, res) => {
// Controller-level defense: allow only COMPANY or MANAGER roles
if (!(req.roleCode === ROLE_TYPE.COMPANY || req.roleCode === ROLE_TYPE.COMPANY_MANAGER)) {
res.message = _localize('auth.permission', req);
return util.unAuthorizedRequest(res);
}

const result = await brainService.deleteAllBrain(req);
if (result) {
res.message = _localize('module.delete', req, BRAIN);
Expand Down Expand Up @@ -135,5 +143,5 @@ module.exports = {
restoreBrain,
deleteAllBrain,
workspaceWiseList
}
}

4 changes: 2 additions & 2 deletions nodejs/src/routes/web/brains.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ const router = express.Router();
const brainController = require('../../controller/web/brainController');
const { createBrainKeys, updateBrainKeys, shareBrainKeys, unshareBrainKeys, shareDocKeys } = require('../../utils/validations/brain');
const { partialUpdateKeys } = require('../../utils/validations/common');
const { authentication } = require('../../middleware/authentication');
const { authentication, checkPermission } = require('../../middleware/authentication');
const { checkPromptLimit } = require('../../middleware/promptlimit');

router.post('/create', validate(createBrainKeys), authentication,checkPromptLimit, brainController.createBrain);
router.put('/update/:id', validate(updateBrainKeys), authentication,checkPromptLimit, brainController.updateBrain);
router.get('/:slug', authentication, brainController.getBrain);
router.delete('/delete/:id', authentication, brainController.deleteBrain);
router.delete('/deleteall', authentication, brainController.deleteAllBrain);
router.delete('/deleteall', authentication, checkPermission, brainController.deleteAllBrain).descriptor('brain.delete_all');
router.post('/list', authentication, checkPromptLimit, brainController.getAll);
router.patch('/partial/:slug', validate(partialUpdateKeys), authentication, brainController.partialUpdate);
router.post('/unshare', validate(unshareBrainKeys), authentication, brainController.unShareBrain);
Expand Down