solve #62#116
Open
KUNDAN1334 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hi @KUNDAN1334, I pulled your PR and ran the application through Docker, but it’s showing Python code — even though we’ve already removed Python from our GitHub repository. Please take a fresh clone of the Weam GitHub repo, where you’ll now find the updated Next.js and Node.js folders. Add your changes to this new codebase, and then we can proceed with the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Feature: Role/permission-based authorization for bulk delete brains endpoint (
DELETE /web/brains/deleteall).Issue Solved:
Previously, any authenticated user could trigger a destructive bulk delete operation. This PR restricts access to only
COMPANYandMANAGERroles with thebrain.delete_allpermission.Additional safeguards include rate limiting, audit logging, feature flag support, and explicit confirmation via request parameter.
Motivation & Context:
Improves security, compliance, and operational safety for destructive API actions.
Change Type
Testing
Test Process:
COMPANYorMANAGERroles andbrain.delete_allpermission can access the endpoint.403 Forbidden.confirm=trueparam is required for deletion.Test Configuration:
Checklist