Interrupt magellan transition animation when navigating between pages…#308
Merged
Interrupt magellan transition animation when navigating between pages…#308
Conversation
… to ensure intercept touch events is set and reset properly.
cmathew
reviewed
Oct 15, 2025
| binding.root.tag = "IntroStep" | ||
| binding.learnMore.setOnClickListener { | ||
| println("viewBinding: $viewBinding") | ||
| viewBinding!! |
Contributor
There was a problem hiding this comment.
this would have crashed otherwise?
Contributor
Author
There was a problem hiding this comment.
I removed this bit now, but yes it was for reproducing a sneaky crash caused by triggering a button click during the transition animation. The transition is a critical moment where the outbound step has been moved to a Hidden state, and so the viewBinding property will return null, but the Step's View is still attached to the window and animating out for a short time. Any input event listeners still attached to that View are still active
cmathew
reviewed
Oct 15, 2025
| direction: Direction, | ||
| backStackOperation: (Deque<NavigationEvent>) -> MagellanTransition | ||
| ) { | ||
| activeTransition?.interrupt() |
Contributor
There was a problem hiding this comment.
null out activeTransition after this?
… as a function of the distance the from / to views need to travel.
cmathew
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to ensure intercept touch events is set and reset properly.
Screen_recording_20251014_220049.mp4