fix: chown workspace parents on create for bind-mode sibling clone - #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bind-mode
postCreateCommandsibling clone failed withPermission deniedwhen the workspace root/workspacesis root-owned — the sibling clone cannot create its directory under a non-writable parent.Fix
Parents-only rootfs fix-up on the create paths of
up,clone, andrebuild:WorkspaceOwnershipgains aparentsOnlyscope — chowns only the parent directories of the workspace path, never the bind target itselfcloneis covered by the existing rootfs walkSpec
specs/changes/workspace-parents-writable/(proposal, spec, tasks)Tests
swift buildcleanWiki
wiki/domain/devcontainer-apple-gaps.mdwiki/conventions/cli-runtime-boundary.md