feat: use friendly DNS create names with hashed resource stems - #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apple
container create --nameis the container id and DNS hostname. Create names are now the sanitizeddevcontainer.jsonname(folder/repo fallback) instead ofadev-{base}-{hash12}.--nameis DNS / human identification only — noadev-prefix and no identity hash.${devcontainerId}, product*-wsvolumes, and Features tags keep the hashed resource stem from folder/repo basename + hash. Confignamedoes not participate.rebuildcreates the replacement under the live computed create name and keeps the same resource stem / workspace volume. Idleadev-*names stay until rebuild.[Y/n], then a new full name; persist sanitizednameand retry. Non-TTY/--jsonfail closed. Same-workspace leftover under a different name stays a delete-hint.containerName(Apple--namealready is the id).Commits
33a3c02feat: use friendly DNS create names with hashed resource stemsa77a4bcfix: omit redundant containerName from success digest and JSON