Skip to content

fix: align lifecycle hooks, feature metadata, and VS Code behavior - #25

Merged
wcgomes merged 7 commits into
mainfrom
fix/align-official-lifecycle
Aug 14, 2026
Merged

fix: align lifecycle hooks, feature metadata, and VS Code behavior#25
wcgomes merged 7 commits into
mainfrom
fix/align-official-lifecycle

Conversation

@wcgomes

@wcgomes wcgomes commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Summary

This branch brings the Apple devcontainer CLI lifecycle behavior and its contracts closer to the official devcontainer model.

  • Align up, clone, rebuild, and start around host-side initializeCommand, lifecycle ordering and failure cleanup, reuse/resume behavior, concurrent object-map hooks, waitFor, userEnvProbe, and shutdownAction admission.
  • Update lifecycle execution, config admission/resolution, metadata labels, feature contributions/remelt handling, command/runtime output, recovery, and success presentation.
  • Clarify VS Code behavior: --vscode gates host opening rather than customization application, start does not apply settings/extensions, and postAttachCommand follows the CLI-attach policy across lifecycle paths.
  • Expand command, unit, recovery, VS Code, and integration coverage for the new lifecycle and attach semantics.
  • Archive the completed lifecycle change under specs/changes/archive/20260814-align-official-lifecycle/, move the delivered VS Code customizations change into its dated archive location while preserving its restored content, and refresh the domain specs and wiki indexes.
  • Make fixture E2E setup inspect for a cached image first, pull only when missing, and skip cleanly when pulling fails; document the TTY-safe swift run adevcontainerTests < /dev/null invocation.

Verification context

The diff adds and updates MiniTest command, unit, recovery, VS Code, and integration cases, including image-cache/pull/skip behavior and protection against duplicate postStartCommand execution during recovery. CONTRIBUTING.md identifies swift run adevcontainerTests as the suite of record and documents the non-interactive invocation. This description does not claim a test run that is not recorded by the branch diff.

@wcgomes wcgomes changed the title docs: restore archived vscode customizations spec fix: align lifecycle hooks, feature metadata, and VS Code behavior Aug 14, 2026
@wcgomes
wcgomes merged commit cf9467f into main Aug 14, 2026
1 check passed
@wcgomes
wcgomes deleted the fix/align-official-lifecycle branch August 14, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant