fix: align lifecycle hooks, feature metadata, and VS Code behavior - #25
Merged
Conversation
Inspect cached images without pulling; pull only when missing and skip on pull failure so the default suite stays green without network. Document TTY-safe `swift run adevcontainerTests < /dev/null`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch brings the Apple devcontainer CLI lifecycle behavior and its contracts closer to the official devcontainer model.
up,clone,rebuild, andstartaround host-sideinitializeCommand, lifecycle ordering and failure cleanup, reuse/resume behavior, concurrent object-map hooks,waitFor,userEnvProbe, andshutdownActionadmission.--vscodegates host opening rather than customization application,startdoes not apply settings/extensions, andpostAttachCommandfollows the CLI-attach policy across lifecycle paths.specs/changes/archive/20260814-align-official-lifecycle/, move the delivered VS Code customizations change into its dated archive location while preserving its restored content, and refresh the domain specs and wiki indexes.swift run adevcontainerTests < /dev/nullinvocation.Verification context
The diff adds and updates MiniTest command, unit, recovery, VS Code, and integration cases, including image-cache/pull/skip behavior and protection against duplicate
postStartCommandexecution during recovery.CONTRIBUTING.mdidentifiesswift run adevcontainerTestsas the suite of record and documents the non-interactive invocation. This description does not claim a test run that is not recorded by the branch diff.