wayvr: add missing ALTTAB.KEYBOARD translation key - #643
Open
sandikodev wants to merge 1 commit into
Open
Conversation
Collaborator
|
please don't add english for non-english locale files. either:
|
Collaborator
|
also, thanks for the PR! |
galister
reviewed
Sep 2, 2026
| "GRAB": "Einzelnes Overlay verschieben", | ||
| "DASH": "Dashboard umschalten", | ||
| "EDIT": "Bearbeitungsmodus umschalten", | ||
| "KEYBOARD": "Toggle keyboard", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "KEYBOARD": "Toggle keyboard", |
galister
reviewed
Sep 2, 2026
| "GRAB": "Mover {$DEFINITIONS.OVERLAY} individual", | ||
| "DASH": "Alternar panel de control", | ||
| "EDIT": "Alternar modo edición", | ||
| "KEYBOARD": "Toggle keyboard", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "KEYBOARD": "Toggle keyboard", |
galister
reviewed
Sep 2, 2026
| "GRAB": "Sposta singolo overlay", | ||
| "DASH": "Attiva/disattiva dashboard", | ||
| "EDIT": "Attiva/disattiva modalità modifica", | ||
| "KEYBOARD": "Toggle keyboard", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "KEYBOARD": "Toggle keyboard", |
galister
reviewed
Sep 2, 2026
| "GRAB": "個別のオーバーレイを移動", | ||
| "DASH": "ダッシュボードの切り替え", | ||
| "EDIT": "編集モードの切り替え", | ||
| "KEYBOARD": "Toggle keyboard", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "KEYBOARD": "Toggle keyboard", |
galister
reviewed
Sep 2, 2026
| "GRAB": "Przesuń pojedynczą nakładkę", | ||
| "DASH": "Przełącz panel sterowania", | ||
| "EDIT": "Przełącz tryb edycji", | ||
| "KEYBOARD": "Toggle keyboard", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "KEYBOARD": "Toggle keyboard", |
galister
reviewed
Sep 2, 2026
| "GRAB": "移动单个覆盖层", | ||
| "DASH": "切换控制面板", | ||
| "EDIT": "切换编辑模式", | ||
| "KEYBOARD": "Toggle keyboard", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "KEYBOARD": "Toggle keyboard", |
galister
requested changes
Sep 2, 2026
galister
left a comment
galister
left a comment
Collaborator
There was a problem hiding this comment.
accept the suggestions and i'll merge it (test will fail but don't worry about that)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ALTTAB.KEYBOARDtranslation key is referenced by the Alt-Tab help overlay for theTbinding (wayvr/src/assets/gui/alttab-help.xml), but it was missing from the language files. At runtime this logsand the "T" row in the help overlay shows an empty label.
Changes
ALTTAB.KEYBOARDkey (English: "Toggle keyboard") to the source templatewayvr/src/assets/lang/en.csven.jsonand all localized files (de,es,it,ja,pl,zh_CN) so the existinglang_json_files_contain_all_keystest keeps passingTesting
cargo test --all-featurespassescargo build --all-featurespasses