ESP8266 compatibility and more characters for setChar()#25
Open
harlock974 wants to merge 2 commits intowayoda:masterfrom
Open
ESP8266 compatibility and more characters for setChar()#25harlock974 wants to merge 2 commits intowayoda:masterfrom
harlock974 wants to merge 2 commits intowayoda:masterfrom
Conversation
added 2 commits
June 15, 2018 21:42
|
This looks like a good fix, except I would simplify the pull request and split it into two parts, so one to fix ESP8266 compilation and another for the character set. This makes it easier for the maintainers to apply and the chance of the pull request getting accepted, e.g. if they agree with one thing but perhaps not with the other. |
|
Hmm, this project seems dead (no commits in last three years), I'll just create my own fork with these changes and use that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESP8266
include <pgmspace.h> in case the controller is not an AVR
Character set
The following characters can now be displayed with setChar():
A b c d E F G H i J L n o P r t Y